fix(dev/typegen): fix non-JS/TS files #12453
Conversation
🦋 Changeset detectedLatest commit: 35b18e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @nowells, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
nowells
force-pushed
the
nstrite/typescript-non-js
branch
2 times, most recently
from
07c5077 to
f21c90c
Compare
|
I have worked around this with |
nowells
changed the title
moduleResolution Node16 and NodeNext for non-JS files.
MichaelDeBoey
changed the title
|
Fixed some conflicts for you. Any chance we could add a test? Not sure if it's possible without a lot of work, but I figured I'd ask. @pcattori should probably approve this, I'd imagine. |
|
Thanks @timdorr! Let me know if there is anything else you need from me! |
|
hi folks! any plans to get this merged? are there any fixes in the meantime? |
|
Wondering if we can get some 👀 on this from @pcattori ? |
|
Looks like it needs some merge conflicts resolved first. |
nowells
force-pushed
the
nstrite/typescript-non-js
branch
3 times, most recently
from
ea82b61 to
cd63ba4
Compare
|
@timdorr thanks, I updated the patch. |
|
Looks like that nuked your CLA signature. Mind adding that back too? |
…JS routes (like .mdx)
When we have a file `./app/routes/test/index.mdx` which is a route we get the following error:
```
.react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations.
10 type Module = typeof import("../index.js")
~~~~~~~~~~~~~
```
nowells
force-pushed
the
nstrite/typescript-non-js
branch
from
cd63ba4 to
7814811
Compare
|
@timdorr womp, sorry about that. fixed and pushed! |
|
Hey @nowells , really appreciate the patience! This was on my list of things to look into during the bug bash a couple weeks ago and somehow slipped through the cracks. Took a bit longer than usual to consider this one since we were considering adding support for "MDX as content" ala Astro content collections (I still think that is ultimately a better solution for non-JS/TS routes), but I think its better to merge this in the meantime and not wait for that architectural change. It would be a breaking change anyway, so I like including this in v7 |
I'm personally not knowledgable at all about custom elements, but I'll make sure we bring it up next time we look at feature requests |
|
🤖 Hello there, We just published version Thanks! |
#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)
When we have a file
./app/routes/test/index.mdxwhich is a route we get the following error: